debug: auto-scroll jitter instrumentation — tick timing, contentSize, loadMore, markRead
All checks were successful
Security Checks / dependency-audit (push) Successful in 13s
Security Checks / secret-scanning (push) Successful in 4s
Security Checks / dockerfile-lint (push) Successful in 3s

This commit is contained in:
Yusuf Suleman
2026-04-04 08:19:30 -05:00
parent 976469f5fe
commit 39b9303918
3 changed files with 31 additions and 6 deletions

View File

@@ -94,15 +94,19 @@ final class ReaderViewModel {
func loadMore() async { func loadMore() async {
guard !isLoadingMore, hasMore else { return } guard !isLoadingMore, hasMore else { return }
isLoadingMore = true isLoadingMore = true
print("[SCROLL-DBG] 📥 loadMore START offset=\(offset)")
do { do {
let list = try await fetchEntries(offset: offset) let list = try await fetchEntries(offset: offset)
let count = list.entries.count
entries.append(contentsOf: list.entries) entries.append(contentsOf: list.entries)
total = list.total total = list.total
offset += list.entries.count offset += count
hasMore = offset < list.total hasMore = offset < list.total
print("[SCROLL-DBG] 📥 loadMore END appended=\(count) total=\(entries.count) hasMore=\(hasMore)")
} catch { } catch {
self.error = error.localizedDescription self.error = error.localizedDescription
print("[SCROLL-DBG] 📥 loadMore FAILED: \(error)")
} }
isLoadingMore = false isLoadingMore = false
} }

View File

@@ -112,6 +112,7 @@ struct EntryListView: View {
frame.maxY < 30 else { return } frame.maxY < 30 else { return }
markedByScroll.insert(entryId) markedByScroll.insert(entryId)
print("[SCROLL-DBG] 📖 markRead id=\(entryId) entriesCount=\(vm.entries.count)")
if let idx = vm.entries.firstIndex(where: { $0.id == entryId }) { if let idx = vm.entries.firstIndex(where: { $0.id == entryId }) {
vm.entries[idx].status = "read" vm.entries[idx].status = "read"

View File

@@ -94,25 +94,45 @@ struct ScrollViewDriver: UIViewRepresentable {
displayLink = nil displayLink = nil
} }
private var lastTickTime: CFAbsoluteTime = 0
private var lastContentSize: CGFloat = 0
private var tickCount = 0
@objc private func tick(_ link: CADisplayLink) { @objc private func tick(_ link: CADisplayLink) {
guard let sv = scrollView else { guard let sv = scrollView else {
stopAndNotify() stopAndNotify()
return return
} }
let now = CFAbsoluteTimeGetCurrent()
let maxOffset = sv.contentSize.height - sv.bounds.height + sv.contentInset.bottom let maxOffset = sv.contentSize.height - sv.bounds.height + sv.contentInset.bottom
guard maxOffset > 0 else { return } guard maxOffset > 0 else { return }
// 60pt/sec at 1.0x speed, scaled by actual frame duration let frameDuration = link.targetTimestamp - link.timestamp
let delta = CGFloat(speed) * 60.0 * CGFloat(link.targetTimestamp - link.timestamp) let expectedDelta = CGFloat(speed) * 60.0 * CGFloat(frameDuration)
let newY = min(sv.contentOffset.y + delta, maxOffset) let beforeY = sv.contentOffset.y
let newY = min(beforeY + expectedDelta, maxOffset)
sv.contentOffset.y = newY sv.contentOffset.y = newY
// Notify delegate so tab bar minimize behavior triggers let actualDelta = sv.contentOffset.y - beforeY
// Detect jitter: contentSize changed, or actual delta differs from expected
let contentSizeChanged = sv.contentSize.height != lastContentSize
let wallDelta = lastTickTime > 0 ? (now - lastTickTime) * 1000 : 0
let isJitter = contentSizeChanged || wallDelta > 25 // >25ms between frames = dropped frame
tickCount += 1
if isJitter || tickCount % 120 == 0 {
// Log on jitter or every 2 seconds
print("[SCROLL-DBG] \(isJitter ? "⚠️ JITTER" : "✅ ok") wallΔ=\(String(format:"%.1f", wallDelta))ms frameDur=\(String(format:"%.1f", frameDuration*1000))ms expΔ=\(String(format:"%.1f", expectedDelta))pt actΔ=\(String(format:"%.1f", actualDelta))pt y=\(Int(sv.contentOffset.y)) contentH=\(Int(sv.contentSize.height)) csChanged=\(contentSizeChanged) speed=\(String(format:"%.2f", speed))")
}
lastTickTime = now
lastContentSize = sv.contentSize.height
originalDelegate?.scrollViewDidScroll?(sv) originalDelegate?.scrollViewDidScroll?(sv)
// Stop at bottom
if newY >= maxOffset - 1 { if newY >= maxOffset - 1 {
stopAndNotify() stopAndNotify()
} }